Skip to content

revert: "chore: add -race -failfast flags to the CI integration tests (#4057)"#4060

Merged
Pantani merged 2 commits intomainfrom
julien/revert-ae8fc1f6cf4e6ba994f07811fe0919f4507f538f
Mar 28, 2024
Merged

revert: "chore: add -race -failfast flags to the CI integration tests (#4057)"#4060
Pantani merged 2 commits intomainfrom
julien/revert-ae8fc1f6cf4e6ba994f07811fe0919f4507f538f

Conversation

@julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Mar 28, 2024

This reverts commit ae8fc1f.

ref: #4001 (comment) and https://github.com/ignite/cli/actions/runs/8469751567/job/23205805178

This is blocking all PRs to be merged

@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs labels Mar 28, 2024
@julienrbrt julienrbrt added the skip-changelog Don't check changelog for new entries label Mar 28, 2024
@julienrbrt julienrbrt changed the title Revert "chore: add -race -failfast flags to the CI integration tests (#4057)" revert: "chore: add -race -failfast flags to the CI integration tests (#4057)" Mar 28, 2024
salmad3
salmad3 approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@salmad3 salmad3 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I understand it, this is a good indication of concurrency issues and we should consider synchronization techniques. Looking at the logs, it seems that there are multiple instances of concurrent access by goroutines, leading to a race condition.

I can open an issue.

@julienrbrt
Copy link
Member Author

julienrbrt commented Mar 28, 2024

Thank you! Yes we should fix the issues before putting this back.

@Pantani
Copy link
Collaborator

Pantani commented Mar 28, 2024

As I understand it, this is a good indication of concurrency issues and we should consider synchronization techniques. Looking at the logs, it seems that there are multiple instances of concurrent access by goroutines, leading to a race condition.

I can open an issue.

I agree, but we found some issues into the codebase more harder to expect to fix, let's solve first and enable the flag again

@Pantani Pantani enabled auto-merge (squash) March 28, 2024 20:15
@Pantani Pantani merged commit a2d2c3c into main Mar 28, 2024
@Pantani Pantani deleted the julien/revert-ae8fc1f6cf4e6ba994f07811fe0919f4507f538f branch March 28, 2024 20:20
@salmad3 salmad3 mentioned this pull request Apr 8, 2024
Closed
4 tasks
julienrbrt added a commit that referenced this pull request May 29, 2024
@julienrbrt @Pantani
Revert "chore: add -race -failfast flags to the CI integration te…
e9f92b2 
…sts (#4057)" (#4060)

This reverts commit ae8fc1f.

Co-authored-by: Danilo Pantani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pantani Pantani Pantani approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi

+1 more reviewer

@salmad3 salmad3 salmad3 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@julienrbrt julienrbrt

Labels

component:ci CI/CD workflow and automated jobs. component:configs skip-changelog Don't check changelog for new entries

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@julienrbrt @Pantani @salmad3